Manchester | 26-ITP-Jan | Ahmed Elmahmoudi | Sprint 1 | Feature Wireframe #1100
Manchester | 26-ITP-Jan | Ahmed Elmahmoudi | Sprint 1 | Feature Wireframe #1100Alaterry8 wants to merge 11 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Alaterry8
added
the
Needs Review
Alaterry8
changed the title
Alaterry8
changed the title
Alaterry8
added
📅 Sprint 1
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code is free of syntax errors and well indented. Well done.
1
When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you
- Center the PAGE TITLE and the SHORT DESCRIPTION beneath it
- Center the text on the footer
?
2
Can you improve the Lighthouse accessibility score to 100?
3
The footer content and the article content could overlap when the user scrolls the content. Can you address this issue (to improve user experience)?
cjyuan
added
Reviewed
Alaterry8
added
Needs Review
|
Hey @cjyuan I added the missing parts and fixed the contrast issue, thanks for the feedback! |
|
You addressed all comments. Good job! However, now one of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", is no longer satisfied. Can you make the necessary change? (Suggestion: Ask ChatGPT what that requirement means). |
cjyuan
added
Reviewed
2 participants
Self checklist
Changelist
I added 3 new articles that contain titles, summaries, images and links. I styled the articles with CSS to change the background colour. I changed the footer colour.